Refactor: expandTilde dedup, USE_DEBUGPY gate, jsonrpc env+ConnectionError, _get_settings_by_path#466
Open
Refactor: expandTilde dedup, USE_DEBUGPY gate, jsonrpc env+ConnectionError, _get_settings_by_path#466
Conversation
Part of Phase 4 normalization (#465). Removes duplicate expandTilde from settings.ts, exports from envFile.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Part of Phase 4 normalization (#465). Aligns with black-formatter pattern — only loads debugpy when USE_DEBUGPY is set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Part of Phase 4 normalization (#465). Aligns with pylint pattern — allows passing environment variables to subprocess. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ception Part of Phase 4 normalization (#465). Aligns with pylint pattern for more specific error typing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
changed the title
edvilme
changed the title
edvilme
force-pushed
the
phase4/trivial-normalizations
branch
from
ae76d78 to
83bc685
Compare
rchiodo
reviewed
Apr 8, 2026
rchiodo
reviewed
Apr 8, 2026
Contributor
|
There's still a bunch of unresolved comments? |
edvilme
force-pushed
the
phase4/trivial-normalizations
branch
from
83bc685 to
97d40f1
Compare
Part of Phase 4 normalization (#465). Aligns with black/isort/mypy/pylint — adds path-based settings lookup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Both comments addressed:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial normalization changes for shared package extraction.
All changes are backwards-compatible refactoring. No behavioral changes.